Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update Simple example so that lastName fails required field validation #3449

Conversation

heath-freenome
Copy link
Member

Reasons for making this change

Issue #3440 describes the required field validation for firstName and lastName not working for the simple example

  • Updated the simple example to remove the ui:emptyValue for the lastName field so that required field validation works for it.
    • Also added a placeholder for firstName indicating that it will never fail validation due to ui:emptyValue

Checklist

  • I'm updating documentation
  • I'm adding or updating code
    • I've added and/or updated tests. I've run npm run test:update to update snapshots, if needed.
    • I've updated docs if needed
    • I've updated the changelog with a description of the PR
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

Screenshot 2023-02-20 at 10 17 13 AM

…dation

Issue rjsf-team#3440 describes the required field validation for `firstName` and `lastName` not working for the simple example
- Updated the simple example to remove the `ui:emptyValue` for the `lastName` field so that required field validation works for it.
  - Also added a placeholder for `firstName` indicating that it will never fail validation due to `ui:emptyValue`
@heath-freenome heath-freenome merged commit 8be4ef2 into rjsf-team:main Feb 21, 2023
@heath-freenome heath-freenome deleted the make-lastName-fail-required-validation branch February 21, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants