fix: Fixes broken playground form display and small mui bug #3583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes rjsf-team#3576 and rjsf-team#3579 by only passing `templates` with non-`undefined` values Fixes rjsf-team#3578 by using `TextField` to render the label key input value - Updated `@rjsf/material-ui` and `@rjsf/mui` to use the `TextField` as the input for the label key value rather than attempting to cobble one togther - Updated the snapshots accordingly - Updated the `Playground` component to only pass `templates` with values that aren't undefined to the main `Form` - Updated the `CHANGELOG.md` accordingly
nickgros
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
Fixes #3576 and #3579 by only passing
templateswith non-undefinedvaluesFixes #3578 by using
TextFieldto render the label key input value@rjsf/material-uiand@rjsf/muito use theTextFieldas the input for the label key value rather than attempting to cobble one togtherPlaygroundcomponent to only passtemplateswith values that aren't undefined to the mainFormCHANGELOG.mdaccordinglyChecklist
npm run test:updateto update snapshots, if needed.