-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: set defaults for oneOf + ref #3634
fix: set defaults for oneOf + ref #3634
Conversation
@anthonycaron There is another PR that will be merged in the next day or so in the same file. Since this one has been going through a few rounds of reviews already, I will wait to review this after we merge that one and you rebase and fix the conflicts that will be coming. |
@anthonycaron The PR was merged. Please rebase and take care of the conflicts! Thanks |
@heath-freenome Done ! |
@anthonycaron This looks great! One last thing, if you can remove the update to the Nevermind, I am going to merge |
@heath-freenome Thanks ! Do you have an idea when the next release will happen ? |
@anthonycaron I'm hoping to get it released soon after I get #3652 merged |
Reasons for making this change
fixes #3633
Checklist
npm run test:update
to update snapshots, if needed.