Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set defaults for oneOf + ref #3634

Conversation

anthonycaron
Copy link
Contributor

@anthonycaron anthonycaron commented May 3, 2023

Reasons for making this change

fixes #3633

Checklist

  • I'm updating documentation
  • I'm adding or updating code
    • I've added and/or updated tests. I've run npm run test:update to update snapshots, if needed.
    • I've updated docs if needed
    • I've updated the changelog with a description of the PR
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

@heath-freenome
Copy link
Member

@anthonycaron There is another PR that will be merged in the next day or so in the same file. Since this one has been going through a few rounds of reviews already, I will wait to review this after we merge that one and you rebase and fix the conflicts that will be coming.

@heath-freenome
Copy link
Member

@anthonycaron The PR was merged. Please rebase and take care of the conflicts! Thanks

@anthonycaron
Copy link
Contributor Author

@heath-freenome Done !

@heath-freenome
Copy link
Member

heath-freenome commented May 9, 2023

@anthonycaron This looks great! One last thing, if you can remove the update to the package-lock.json file I would appreciate it. It will be updated by the publishing process anyway. Then I will approve and merge

Nevermind, I am going to merge

@heath-freenome heath-freenome merged commit 92e5448 into rjsf-team:main May 10, 2023
@anthonycaron
Copy link
Contributor Author

@heath-freenome Thanks ! Do you have an idea when the next release will happen ?

@heath-freenome
Copy link
Member

@anthonycaron I'm hoping to get it released soon after I get #3652 merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default values are not set for oneOf + ref in schema
2 participants