Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiled/ExpandAllBranches Resolve AllOf Schemas #3764

Merged

Conversation

cwendtxealth
Copy link
Contributor

@cwendtxealth cwendtxealth commented Jul 13, 2023

Reasons for making this change

When using pre compiled schemas with large allOf's mixed with if/thens, the if's will never be resolved to a single schema because of no form data. This causes mergeAllOf to always throw an error could not merge subschemas in allOf: and makes the schema compiling very slow. This fix will just return the allOf sub schemas to be resolved without trying to merge them together.

Checklist

  • I'm updating documentation
  • I'm adding or updating code
    • I've added and/or updated tests. I've run npm run test:update to update snapshots, if needed.
    • I've updated docs if needed
    • I've updated the changelog with a description of the PR
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

@heath-freenome
Copy link
Member

@cwendtxealth Another good fix! I just fixed another precompiled schema issue in the latest 5.10.0 release. Can you resolve conflicts and then update CHANGELOG.md with a 5.10.1 statement?

@heath-freenome heath-freenome merged commit 2f891e7 into rjsf-team:main Jul 13, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants