Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Updated bump-all-packages to remove the lerna run --stream #3773

Conversation

heath-freenome
Copy link
Member

@heath-freenome heath-freenome commented Jul 15, 2023

Reasons for making this change

With the advent of npm workspaces, the bumping of packages in the package.json files of each workspace element happens automatically rather than needing to use lerna run --stream

  • Updated the root package.json to remove the lerna run --stream of each sub-package package.json and folded in the main bump-packages script directly into the bump-all-packages script
  • Removed the bump-packages script from each of the sub-package package.json files
  • Updated the CHANGELOG.md file accordingly

Checklist

  • I'm updating documentation
  • I'm adding or updating code
    • I've added and/or updated tests. I've run npm run test:update to update snapshots, if needed.
    • I've updated docs if needed
    • I've updated the changelog with a description of the PR
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

With the advent of npm workspaces, the bumping of packages in the `package.json` files of each workspace element happens automatically rather than needing to use `lerna --stream`
- Updated the root `package.json` to remove the `lerna --stream` of each sub-package `package.json` and folded in the main `bump-packages` command directly into the `bump-all-packages` script
- Removed the `bump-packages` script from each of the sub-package `package.json` files
- Updated the `CHANGELOG.md` file accordingly
@heath-freenome heath-freenome changed the title fix: Updated bump-all-packages to remove the lerna run --stream chore: Updated bump-all-packages to remove the lerna run --stream Jul 15, 2023
@heath-freenome heath-freenome merged commit 0e15118 into rjsf-team:main Jul 15, 2023
@heath-freenome heath-freenome deleted the fix-bump-all-packages-with-workspaces branch July 15, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants