Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update playground vite config to use sources directly #3779

Merged
merged 2 commits into from
Jul 21, 2023

Conversation

zxbodya
Copy link
Contributor

@zxbodya zxbodya commented Jul 21, 2023

Updating vite configuration to use source of packages inside monorepo directly, avoiding the compilation step

Reasons for making this change

This is to improve developer experience using playground, allowing instant reload for changes inside monorepo bypassing need of the build step

Updating vite configuration to use source of packages in monorepo directly avoiding compilation step
Copy link
Contributor

@nickgros nickgros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, pending local check of the built playground

@heath-freenome heath-freenome merged commit c076e35 into rjsf-team:main Jul 21, 2023
@zxbodya zxbodya deleted the vite-use-sources branch July 21, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants