typescript project references #3782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zxbodya
force-pushed
the
ts-references
branch
4 times, most recently
from
0364029
to
584b9e2
Compare
zxbodya
force-pushed
the
ts-references
branch
5 times, most recently
from
9701e04
to
c2b6678
Compare
|
@zxbodya Will you have a chance to update and resolve the conflicts in this PR? |
|
@zxbodya Let's get this merged into |
zxbodya
force-pushed
the
ts-references
branch
from
97cae32
to
5a6e862
Compare
|
@zxbodya Ok, the new fluent-rc theme is merged, please rebase, update and ready your PR for merge ASAP. I hope to cut a new release by monday |
zxbodya
force-pushed
the
ts-references
branch
from
0ec9d99
to
c846f0e
Compare
There was a problem hiding this comment.
@zxbodya A couple of small tweaks and then I'll merge and build a new release
CHANGELOG.md
Outdated
Comment on lines
20
to
27
| ## Dev / playground | ||
|
|
||
| - update configuration to use typescript project references, start type checking the tests | ||
|
|
||
| ## @rjsf/snapshot-tests | ||
|
|
||
| Move theme snapshot tests into separate package | ||
|
|
There was a problem hiding this comment.
Can you reorder these to be after @rjsf/fluentui-rc with @rjsf/snapshot-tests first?
packages/snapshot-tests/README.md
Outdated
| <h3 align="center">@rjsf/snapshot-tests</h3> | ||
|
|
||
| <p align="center"> | ||
| Core logic and classic Bootstrap 3 theme for <a href="https://github.com/rjsf-team/react-jsonschema-form/"><code>react-jsonschema-form</code></a>. |
There was a problem hiding this comment.
This needs updating to be relevant to the repo rather than a copy of core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding configuration for typescript project references
As part of it also splitted snapTests from core to separate package - this is to avoid imports for code not included in package exports, and also will allow themes developed outside oof this monorepo to depend on it.
Reasons for making this change
depends on #3781