Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix isMultiple check by adding compare with false #3811

Merged
merged 3 commits into from
Sep 1, 2023

Conversation

antpaw
Copy link
Contributor

@antpaw antpaw commented Aug 4, 2023

Reasons for making this change

This fixes the issue where chakra-ui would render a multiselect for a oneOf field select

Checklist

  • I'm updating documentation
  • I'm adding or updating code
    • I've added and/or updated tests. I've run npm run test:update to update snapshots, if needed.
    • I've updated docs if needed
    • I've updated the changelog with a description of the PR
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

Copy link
Member

@heath-freenome heath-freenome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase and update the CHANGELOG.md

@heath-freenome
Copy link
Member

@antpaw Just a little bit more work and we can get this over the line

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Nick Grosenbacher <nickgrosenbacher@gmail.com>
CHANGELOG.md Outdated Show resolved Hide resolved
@nickgros
Copy link
Contributor

nickgros commented Sep 1, 2023

Looks good, thanks @antpaw ! I will merge this as soon as it passes and we'll release 5.12.2 soon!

@nickgros nickgros removed the request for review from heath-freenome September 1, 2023 13:12
@nickgros nickgros dismissed heath-freenome’s stale review September 1, 2023 13:14

Requested changes were made

@nickgros nickgros merged commit b07eda3 into rjsf-team:main Sep 1, 2023
4 checks passed
@antpaw antpaw deleted the fix-mulitple-select branch September 1, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants