fix: programmatic validation removes previous errors if all data is now valid #3855
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
Programatic validation doesn't clear the errors if the form has been changed from being invalid -> valid. This results in stale errors remaining.
Reproduction steps:
Expected: The error should disappear after clearing invalid data and re-validating.
Actual: The error remains after clearing invalid data and re-validating.
Workaround:
Pass additional props when rendering
Form
so the state will still be updated if there are no errors:Checklist
npm run test:update
to update snapshots, if needed.