fix: errorSchema is not correctly updated when inserting or copying array items #3874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jordyjordy Good fix! Can you resolve the conflicts in |
|
@heath-freenome Because i don't have experience resolving upstream conflicts I rebased a fix branch and cherry picked my commits. That seems to have closed this PR because for a moment there were 0 code changes. I reopened it and the conflicts should now be resolved |
heath-freenome
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
When swapping or removing array items, the existing errorSchema is correctly updated. However this was not the case when inserting or copying array elements. Inserting array elements is not implementedby the default ArrayItemTemplate, but it is still possible from custom templates.
To test the "insert" functionality I added a custom ArrayItemTemplate to the ArrayField tests. If this is not the way, or if there is a better way to test this please let me know and I can update them.
Checklist
npm run test:updateto update snapshots, if needed.