Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Implements #297 request #3878

Closed
wants to merge 0 commits into from
Closed

Conversation

Shubhcoder
Copy link
Contributor

@Shubhcoder Shubhcoder commented Sep 21, 2023

Reasons for making this change

I have added the code (with tests) to implement the feature requested in #297.

Checklist

  • I'm updating documentation
  • I'm adding or updating code
    • I've added and/or updated tests. I've run npm run test:update to update snapshots, if needed.
    • I've updated docs if needed
    • I've updated the changelog with a description of the PR
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

@heath-freenome
Copy link
Member

@Shubhcoder Thanks for this coding work. Due to some unfortunate copy/paste work done by previous theme authors, we actually have similar code in both the antd and chakra-ui themes. I've been meaning to take the time to refactor the duplicate (non-React component) based functions down into the @rjsf/utils package. Is this something you are willing to do as part of your fix?

@Shubhcoder
Copy link
Contributor Author

Hi, @heath-freenome

Sure, I would love to work on it.

@heath-freenome
Copy link
Member

@Shubhcoder did you mean to close this?

@Shubhcoder
Copy link
Contributor Author

Hi, @heath-freenome

Yes, I will make another pr with the refactor code you were talking about.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants