correct antd SelectWidget filter option check. fix PR #3377 #3919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nickgros review please |
|
@hextion Can you please rebase and update the |
Nevermind, I'm pushing a fix today and will update the changelog |
heath-freenome
approved these changes
Oct 28, 2023
heath-freenome
added a commit
to heath-freenome/react-jsonschema-form
that referenced
this pull request
Oct 28, 2023
… items Fixes rjsf-team#3924 by defaulting to an empty object for the `itemSchema` when undefined - In `@rjsf/core` updated `ArrayField`'s `renderFixedArray()` to default the `itemSchema` to an empty object if it is falsy - Updated the tests for `ArrayField` to verify the fix - Updated `CHANGELOG.md` accordingly - Also added entry for the fix for rjsf-team#3919
8 tasks
heath-freenome
added a commit
to heath-freenome/react-jsonschema-form
that referenced
this pull request
Oct 28, 2023
… items Fixes rjsf-team#3924 by defaulting to an empty object for the `itemSchema` when undefined Fixes rjsf-team#3927 by fixing `getSnapshotBeforeUpdate()` added for the fix rjsf-team#1794 - In `@rjsf/core` updated `ArrayField`'s `renderFixedArray()` to default the `itemSchema` to an empty object if it is falsy - Updated the tests for `ArrayField` to verify the fix - Updated the `getSnapshotBeforeUpdate()` to diff the old and new props and to set the `shouldUpdate` prop if the old and new state differs - Updated `CHANGELOG.md` accordingly - Also added entry for the fix for rjsf-team#3919
heath-freenome
added a commit
to heath-freenome/react-jsonschema-form
that referenced
this pull request
Oct 28, 2023
… items Fixes rjsf-team#3924 by defaulting to an empty object for the `itemSchema` when undefined Fixes rjsf-team#3927 by fixing `getSnapshotBeforeUpdate()` added for the fix rjsf-team#1794 - In `@rjsf/core` updated `ArrayField`'s `renderFixedArray()` to default the `itemSchema` to an empty object if it is falsy - Updated the tests for `ArrayField` to verify the fix - Updated the `getSnapshotBeforeUpdate()` to diff the old and new props and to set the `shouldUpdate` prop if the old and new state differs - Updated `CHANGELOG.md` accordingly - Also added entry for the fix for rjsf-team#3919
heath-freenome
added a commit
to heath-freenome/react-jsonschema-form
that referenced
this pull request
Oct 28, 2023
… items Fixes rjsf-team#3924 by defaulting to an empty object for the `itemSchema` when undefined Fixes rjsf-team#3927 by fixing `getSnapshotBeforeUpdate()` added for the fix rjsf-team#1794 - In `@rjsf/core` updated `ArrayField`'s `renderFixedArray()` to default the `itemSchema` to an empty object if it is falsy - Updated the tests for `ArrayField` to verify the fix - Updated the `getSnapshotBeforeUpdate()` to diff the old and new props and to set the `shouldUpdate` prop if the old and new state differs - Updated `CHANGELOG.md` accordingly - Also added entry for the fix for rjsf-team#3919
|
@heath-freenome sorry I was out of town so I couldn't do stuff. thank you for accepting PR, really appreciate it |
heath-freenome
added a commit
that referenced
this pull request
Oct 30, 2023
…3929) Fixes #3924 by defaulting to an empty object for the `itemSchema` when undefined Fixes #3927 by fixing `getSnapshotBeforeUpdate()` added for the fix #1794 - In `@rjsf/core` updated `ArrayField`'s `renderFixedArray()` to default the `itemSchema` to an empty object if it is falsy - Updated the tests for `ArrayField` to verify the fix - Updated the `getSnapshotBeforeUpdate()` to diff the old and new props and to set the `shouldUpdate` prop if the old and new state differs - Updated `CHANGELOG.md` accordingly - Also added entry for the fix for #3919
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello everyone
Filtering made in #3377 isn't working because
Select.Optiondoesn't havelabelprop passed into.So I fixed that