Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Form.tsx and make submit method public #4029

Merged
merged 6 commits into from
Jan 8, 2024

Conversation

popmanhe
Copy link
Contributor

@popmanhe popmanhe commented Jan 6, 2024

Reasons for making this change

The submit method is not a public method. Somehow, it does not work in some senarios.

If this is related to existing tickets, include links to them as well. Use the syntax fixes #[issue number] (ex: fixes #123).

If your PR is non-trivial and you'd like to schedule a synchronous review, please add it to the weekly meeting agenda: https://docs.google.com/document/d/12PjTvv21k6LIky6bNQVnsplMLLnmEuypTLQF8a-8Wss/edit

Checklist

  • I'm updating documentation
  • [x ] I'm adding or updating code
    • [x ] I've added and/or updated tests. I've run npm run test:update to update snapshots, if needed.
    • I've updated docs if needed
    • I've updated the changelog with a description of the PR
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

@heath-freenome
Copy link
Member

@popmanhe Can you please update your PR after running npm run cs-format? The linter is failing

@popmanhe
Copy link
Contributor Author

popmanhe commented Jan 7, 2024

npm run cs-format executed

@heath-freenome
Copy link
Member

@popmanhe And can you also update the CHANGELOG.md for core explaining the fix and referencing the issue. Thanks!

CHANGELOG.md Outdated Show resolved Hide resolved
@heath-freenome heath-freenome merged commit 8c685b7 into rjsf-team:main Jan 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants