feature: Added better support for testing with AJV having discriminator option turned on #4257
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
A recent issue made it clear that we didn't make it easy for users to turn on
discriminator
support from AJV@rjsf/utils
improved support fordiscriminator
as follows:ValidatorType
to add support for an optionalreset()
methodParserValidator
to implementreset()
to clear the schema map, including a test to verify thatdiscriminator
to remove themapping
block that AJV doesn't supportgetFirstMatchingOption()
test to deal with the situation where AJV doesn't support discriminator for array typesretrieveSchema()
test to callreset()
on validators that have it in anafterEach()
getTestValidator()
implementation to implement areset()
that empties the arrays@rjsf/validator-ajv8
improved support fordiscriminator
as follows:createAjvInstance()
function to denote that we want to makediscriminator: true
the default in v6AJV8Validator
to make reset doajv.removeSchema()
to clear the cached schemasgetTestValidator() implementation to call
reset()` on the validator if it existsschema.test.ts
file to run a set of test withdiscriminator: true
set on theAJV8Validator
CHANGELOG.md
file accordinglyChecklist
npx nx run-many --target=build --exclude=@rjsf/docs && npm run test:update
to update snapshots, if needed.