fix querySelector in Form focusOnError when id includes dots #4280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -837,7 +837,7 @@ export default class Form< | |||
| let field = this.formElement.current.elements[elementId]; | |||
| if (!field) { | |||
| // if not an exact match, try finding an input starting with the element id (like radio buttons or checkboxes) | |||
| field = this.formElement.current.querySelector(`input[id^=${elementId}`); | |||
| field = this.formElement.current.querySelector(`input[id^="${elementId}"`); | |||
There was a problem hiding this comment.
This seems like a straightforward change. Are you willing to add a test to verify it was fixed?
There was a problem hiding this comment.
@heath-freenome apologies, I made this PR right before going on vacation. I see it's been merged but would you still like me to add a unit test?
There was a problem hiding this comment.
@heath-freenome apologies, I made this PR right before going on vacation. I see it's been merged but would you still like me to add a unit test?
@jroebu14 If you could, that would be great! Hope you had a great vacation
|
@jroebu14 Can you also update the |
heath-freenome
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
Fixes #4279
Fixes
FormcomponentfocusOnFirstErrorthrowing an error withadditionalPropertiesschema and dotidSchemae.g.Fixes by adding double quotes around id in query selector.
Checklist
npx nx run-many --target=build --exclude=@rjsf/docs && npm run test:updateto update snapshots, if needed.