Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat: improve deepEquals performance (#4292)" #4300

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

igorbrasileiro
Copy link
Contributor

@igorbrasileiro igorbrasileiro commented Sep 13, 2024

Reasons for making this change

This reverts the pr #4292 due to maximum call stack exceeded issue reported #4292 (comment)

If your PR is non-trivial and you'd like to schedule a synchronous review, please add it to the weekly meeting agenda: https://docs.google.com/document/d/12PjTvv21k6LIky6bNQVnsplMLLnmEuypTLQF8a-8Wss/edit

Checklist

  • I'm updating documentation
  • I'm adding or updating code
    • I've added and/or updated tests. I've run npx nx run-many --target=build --exclude=@rjsf/docs && npm run test:update to update snapshots, if needed.
    • I've updated docs if needed
    • I've updated the changelog with a description of the PR
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

@heath-freenome
Copy link
Member

@igorbrasileiro Thanks for the roll back... I'm curious if you make, as the first step, the change to have utils use deepEquals() in all the places where we have isEqual() now, does the problem reproduce for you? That will let us know whether we should be looking at the deepEquals() implementation or if one of the isEqual() calls returns a different value than deepEquals()

@heath-freenome heath-freenome merged commit a4bb2bf into rjsf-team:main Sep 13, 2024
5 checks passed
@igorbrasileiro
Copy link
Contributor Author

The issue I was getting, is not related to the #4292 changes, the problem happened in the version before 5.21.0. Sorry for the confusion.

To make it clear, my issue is related to this problem #4262 (comment) .

This issue is related to #4292 , I didn't have success trying to reproduce the issue #4292 (comment) , but I'm still trying to find a way to

igorbrasileiro added a commit to igorbrasileiro/react-jsonschema-form that referenced this pull request Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants