Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Pass required props to anyof/oneof field components #4303

Conversation

tomaszdurka
Copy link
Contributor

@tomaszdurka tomaszdurka commented Sep 14, 2024

Reasons for making this change

required is not passed into AnyOfField/OneOfField fields from SchemaField.

Example case

In case of following schema:

{
  "type": "object",
  "properties": {
    "textOrNumber": {
      "oneOf": [
        {"type": "string"},
        {"type": "number"}
      ]
    }
  },
  "required": ["textOrNumber"]
}

Actual result:

required is not passed down to AnyOfField/OneOfField fields from SchemaField.
textOrNumber is not required (no asterisk)

image

Expected result

After the fix.
Required is passed down, fields render with proper required value.
textOrNumber is required (asterisk present)

image

Checklist

  • I'm updating documentation
  • I'm adding or updating code
    • I've added and/or updated tests. I've run npx nx run-many --target=build --exclude=@rjsf/docs && npm run test:update to update snapshots, if needed.
    • I've updated docs if needed
    • I've updated the changelog with a description of the PR
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

@heath-freenome heath-freenome merged commit d2ac1c1 into rjsf-team:main Sep 20, 2024
5 checks passed
heath-freenome added a commit to heath-freenome/react-jsonschema-form that referenced this pull request Sep 20, 2024
Updated `CHANGELOG.md` to add details for the simple fix provided in rjsf-team#4303
heath-freenome added a commit that referenced this pull request Sep 20, 2024
Updated `CHANGELOG.md` to add details for the simple fix provided in #4303
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants