-
Notifications
You must be signed in to change notification settings - Fork 34
fix:deprecated numpy type #144
base: master
Are you sure you want to change the base?
Conversation
@rjw57 rjw57 I fixed the tests. There is one failing but I do not quite get the reason:
|
@rjw57 - Just drawing attention to this as I've been having the same issue. Also, @zar3bski: Is there value in using |
Yes, because numpy arrays relies on these specific types for memory allocation rather than Python built in types |
@rjw57 Any plan to merge this soon? This is needed to make |
Hello, @xir4n and I are encountering the same problem as others. It would be good to merge this and release a new version of dtcwt on PyPI, so that current versions of NumPy (and Python itself) can be supported. |
Hello everyone, with permission from @rjw57, we have forked this repository with @xir4n and have merged this pull request. |
I've asked @lostanlen and @xir4n for their PyPI usernames so they can upload a release there too. |
Stacktrace motivating this PR
I experienced the following issue while using
dtcwt.Transform1d.forward
Environment
Precision required?
I went with int64, not sure whether this is an overkill for the current need