Skip to content

Commit

Permalink
fix [tool.setuptools] reference in custreamz config (rapidsai#16365)
Browse files Browse the repository at this point in the history
Noticed this warning in logs from rapidsai#16183 

> _/python3.10/site-packages/setuptools/config/pyprojecttoml.py:70: _ToolsTypoInMetadata: Ignoring [tools.setuptools] in pyproject.toml, did you mean [tool.setuptools]?_

This fixes that.

## Notes for Reviewers

Intentionally targeting this at 24.10.

This misconfiguration has been in `custreamz` since the 23.04 release ([git blame link](https://github.com/rapidsai/cudf/blame/e6d412cba7c23df7ee500c28257ed9281cea49b9/python/custreamz/pyproject.toml#L60)).

I think the only effect might be that some test files are included in wheels when we don't want to.

I don't think the fix for it needs to be rushed into 24.08.

I searched across RAPIDS in case this was copied from somewhere else... don't see any other instances of this typo that need to be fixed.

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Vyas Ramasubramani (https://github.com/vyasr)

URL: rapidsai#16365
  • Loading branch information
jameslamb authored and rjzamora committed Jul 30, 2024
1 parent 6a3cd99 commit 8a2c81c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion python/custreamz/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ zip-safe = false
[tool.setuptools.dynamic]
version = {file = "custreamz/VERSION"}

[tools.setuptools.packages.find]
[tool.setuptools.packages.find]
include = [
"custreamz",
"custreamz.*",
Expand Down

0 comments on commit 8a2c81c

Please sign in to comment.