Skip to content
This repository has been archived by the owner on Jun 9, 2020. It is now read-only.

MNT: Always compile Cython at build time #149

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

MNT: Always compile Cython at build time #149

wants to merge 3 commits into from

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Mar 20, 2019

Related issues: #127, #132, #133, #145

Someone with more setuptools-fu than me should double check on this PR.

@jhunkeler
Copy link

setup_requires is only useful for python setup.py [cmd]. Consider adding cython as a [build-system] requirement in pyproject.toml (PEP-517) so pip users can build it from source too 😁

@mayankmadan mayankmadan mentioned this pull request Apr 23, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pllim @jhunkeler