Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gv increases the quickfix window's height each time it's run #11

Closed
losingkeys opened this issue May 2, 2013 · 8 comments · Fixed by #30
Closed

gv increases the quickfix window's height each time it's run #11

losingkeys opened this issue May 2, 2013 · 8 comments · Fixed by #30
Labels
enhancement

Comments

@losingkeys
Copy link
Collaborator

Seems like an unwanted side-effect
@rking
Copy link
Owner

rking commented May 3, 2013

Urr, yeah, that sounds odd.

I'm finally winding down the thunderstorm that was RailsConf; will look at it on the plane tomorrow. =)

@losingkeys
Copy link
Collaborator Author

Cheers!

On May 3, 2013, at 3:44 AM, ☈king notifications@github.com wrote:

Urr, yeah, that sounds odd.

I'm finally winding down the thunderstorm that was RailsConf; will look at it on the plane tomorrow. =)

—
Reply to this email directly or view it on GitHub.

rking added a commit that referenced this issue May 4, 2013
@rking
Don't grow after gv. In fact, shrink // re: #11
ffd4183
@rking
Copy link
Owner

rking commented May 4, 2013

How's this?

@losingkeys
Copy link
Collaborator Author

Hmm, that opens a new split each time (rather than focusing the window that the file is already open in). I'll see if I can take a crack at it here next week sometime

@rking
Copy link
Owner

rking commented May 4, 2013

I'm confused.

What is your expected behavior? The original ack.vim's description of the functionality is to silently open the result in a vsplit.

@losingkeys losingkeys mentioned this issue Sep 20, 2013
Closed
@losingkeys
Copy link
Collaborator Author

Any opinions on this? It might be good to use the default height, and provide an option (like in #20, I think) to change the default quickfix height.

losingkeys added a commit to losingkeys/ag.vim that referenced this issue Dec 6, 2013
@losingkeys
Use the default quickfix window height for gv
78a219b 
Closes rking#11
@losingkeys
Copy link
Collaborator Author

This'll be fixed once #29 is merged

losingkeys added a commit to losingkeys/ag.vim that referenced this issue Dec 13, 2013
@losingkeys
Use the quickfix/location list height in gv
5c7a6c9 
Before this was just being set to something similar to the default
height. Though this code is harder to read, it fixes the following:
- Close the right list (the location list or the quickfix window). This
  is fixed for the `e` and `q` commands too.
- If someone specifies a height (e.g. `let g:ag_qhandler="copen 50"`)
  then `gv` will be less jarring because when the quickfix window is
  re-opened it'll be 50 lines again.

The `gv`, `e`, and `q` mappings depended on a local variable that won't
be available when the mapping was used, so |:execute| was used for those
mappings to evaluate that variable when the mappings are made.

Fixes rking#11

Thanks to @sigmavirus24 for helping out with this one :)
@losingkeys losingkeys mentioned this issue Dec 13, 2013
Merged
@losingkeys
Copy link
Collaborator Author

See #30 for a better fix for this

losingkeys added a commit to losingkeys/ag.vim that referenced this issue Dec 20, 2013
@losingkeys
Use the quickfix/location list height in gv
57f9eb7 
Before this was just being set to something similar to the default
height. Though this code is harder to read, it fixes the following:
- Close the right list (the location list or the quickfix window). This
  is fixed for the `e` and `q` commands too.
- If someone specifies a height (e.g. `let g:ag_qhandler="copen 50"`)
  then `gv` will be less jarring because when the quickfix window is
  re-opened it'll be 50 lines again.

The `gv`, `e`, and `q` mappings depended on a local variable that won't
be available when the mapping was used, so |:execute| was used for those
mappings to evaluate that variable when the mappings are made.

Fixes rking#11

Thanks to @sigmavirus24 for helping out with this one :)
Numkil referenced this issue in Numkil/ag.nvim Dec 18, 2015
@amerlyq @albfan
Rfc: extracted syntax file from ag#group#search
1defc3d 
- Plus function was split to prepare to following refactoring
- Experimental simplification of regex escaping for highlighting

Ref rking#50, Ref #11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
2 participants
@losingkeys @rking