Skip to content

Commit

Permalink
staging: tidspbridge: always compile dsp wdt code
Browse files Browse the repository at this point in the history
In order to detect it at runtime, we need the code handling wdt
clock available at runtime to decide whether to enable or disable
based on the baseimage symbols. Default timeout has been set to 5
seconds.

Downside is that we will lose the option to set a custom timeout
for overflow, but than can be added (if needed) as part of debugfs.

Signed-off-by: Omar Ramirez <omar.ramirez@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Omar Ramirez Luna authored and gregkh committed Feb 24, 2012
1 parent 81a1495 commit 18db4fe
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 43 deletions.
16 changes: 0 additions & 16 deletions drivers/staging/tidspbridge/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -52,22 +52,6 @@ config TIDSPBRIDGE_CACHE_LINE_CHECK
This can lead to heap corruption. Say Y, to enforce the check for 128
byte alignment, buffers failing this check will be rejected.

config TIDSPBRIDGE_WDT3
bool "Enable watchdog timer"
depends on TIDSPBRIDGE
help
WTD3 is managed by DSP and once it is enabled, DSP side bridge is in
charge of refreshing the timer before overflow, if the DSP hangs MPU
will caught the interrupt and try to recover DSP.

config TIDSPBRIDGE_WDT_TIMEOUT
int "Watchdog timer timeout (in secs)"
depends on TIDSPBRIDGE && TIDSPBRIDGE_WDT3
default 5
help
Watchdog timer timeout value, after that time if the watchdog timer
counter is not reset the wdt overflow interrupt will be triggered

config TIDSPBRIDGE_NTFY_PWRERR
bool "Notify power errors"
depends on TIDSPBRIDGE
Expand Down
24 changes: 1 addition & 23 deletions drivers/staging/tidspbridge/core/wdt.c
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,6 @@
#include <dspbridge/host_os.h>


#ifdef CONFIG_TIDSPBRIDGE_WDT3

#define OMAP34XX_WDT3_BASE (L4_PER_34XX_BASE + 0x30000)

static struct dsp_wdt_setting dsp_wdt;
Expand Down Expand Up @@ -84,7 +82,7 @@ int dsp_wdt_init(void)
void dsp_wdt_sm_set(void *data)
{
dsp_wdt.sm_wdt = data;
dsp_wdt.sm_wdt->wdt_overflow = CONFIG_TIDSPBRIDGE_WDT_TIMEOUT;
dsp_wdt.sm_wdt->wdt_overflow = 5; /* in seconds */
}


Expand Down Expand Up @@ -128,23 +126,3 @@ void dsp_wdt_enable(bool enable)
clk_disable(dsp_wdt.fclk);
}
}

#else
void dsp_wdt_enable(bool enable)
{
}

void dsp_wdt_sm_set(void *data)
{
}

int dsp_wdt_init(void)
{
return 0;
}

void dsp_wdt_exit(void)
{
}
#endif

4 changes: 0 additions & 4 deletions drivers/staging/tidspbridge/include/dspbridge/_chnl_sm.h
Original file line number Diff line number Diff line change
Expand Up @@ -99,14 +99,10 @@ struct shm {
struct opp_rqst_struct opp_request;
/* load monitor information structure */
struct load_mon_struct load_mon_info;
#ifdef CONFIG_TIDSPBRIDGE_WDT3
/* Flag for WDT enable/disable F/I clocks */
u32 wdt_setclocks;
u32 wdt_overflow; /* WDT overflow time */
char dummy[176]; /* padding to 256 byte boundary */
#else
char dummy[184]; /* padding to 256 byte boundary */
#endif
u32 shm_dbg_var[64]; /* shared memory debug variables */
};

Expand Down

0 comments on commit 18db4fe

Please sign in to comment.