Skip to content

Commit

Permalink
DOM: Deprecate ContainerFactory#FromAny() method
Browse files Browse the repository at this point in the history
This should never be part of this interface.
Its implementation is very opiononated and can be achieved by various ways
by caller. Deprecate and remove it later.

Signed-off-by: Richard Kosegi <richard.kosegi@gmail.com>
  • Loading branch information
rkosegi committed Aug 28, 2024
1 parent bc350e0 commit c0844c3
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion dom/types.go
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,8 @@ type ContainerFactory interface {
// FromProperties is similar to FromMap except that keys are parsed into path before inserting into ContainerBuilder
FromProperties(in map[string]interface{}) ContainerBuilder
// FromAny creates ContainerBuilder from any object. Any error encountered in process will result in panic.
// This method uses YAML codec internally to perform translation between raw interface and map
// This method uses YAML codec internally to perform translation between raw interface and map.
// Deprecated, do not use. Same can be simply achieved by various ways by caller himself.
FromAny(v interface{}) ContainerBuilder
}

Expand Down

0 comments on commit c0844c3

Please sign in to comment.