DOM: Fix sematics of ContainerBuilder.FromMap() #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Up until this commit, FromMap() treated map keys as property paths,
which means ANY value is coerced into LeafNode.
More correct behavior is to not treat them as such, but pass them as-is
into existing code (appendMap). This will simplify code path and make
it more logical overall.
Previous behavior can be easily achieved to foreign callers using public API:
```go
c := dom.Builder().Container()
for k, v := range in {
c.AddValueAt(k, dom.LeafNode(v))
}
return c
```
Signed-off-by: Richard Kosegi <richard.kosegi@gmail.com>
|
rkosegi
added a commit
that referenced
this pull request
May 17, 2024
Fix introduced in #10 changed FromMap() semantics, which might still be desirable in some cases. Create factory method FromProperties() that will use old way of initialising Signed-off-by: Richard Kosegi <richard.kosegi@gmail.com>
rkosegi
added a commit
that referenced
this pull request
May 17, 2024
Fix introduced in #10 changed FromMap() semantics, which might still be desirable in some cases. Create factory method FromProperties() that will use old way of initialising Signed-off-by: Richard Kosegi <richard.kosegi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up until this commit, FromMap() treated map keys as property paths,
which means ANY value is coerced into LeafNode.
More correct behavior is to not treat them as such, but pass them as-is
into existing code (appendMap). This will simplify code path and make
it more logical overall.
Previous behavior can be easily achieved to foreign callers using public API:
Signed-off-by: Richard Kosegi richard.kosegi@gmail.com