Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOM: Return self refernce on builder interfaces for builder chain support. #71

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

rkosegi
Copy link
Owner

@rkosegi rkosegi commented Aug 28, 2024

It make sense to support chaining in some of builder methods, eg:

cb := Builder().Container()
cb.AddValue("leaf1, LeafNode(10)).Remove("old-leaf") ....

Signed-off-by: Richard Kosegi richard.kosegi@gmail.com

…port.

It make sense to support chaining in some of builder methods, eg:

```go
cb := Builder().Container()
cb.AddValue("leaf1, LeafNode(10)).Remove("old-leaf") ....
```

Signed-off-by: Richard Kosegi <richard.kosegi@gmail.com>
Copy link

sonarcloud bot commented Aug 28, 2024

@rkosegi rkosegi merged commit e1106df into main Aug 28, 2024
2 checks passed
@rkosegi rkosegi deleted the feature/dom-builder-chain branch August 28, 2024 10:33
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.41%. Comparing base (3d2ca20) to head (ecdd8c1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #71   +/-   ##
=======================================
  Coverage   99.41%   99.41%           
=======================================
  Files          46       46           
  Lines        2205     2213    +8     
=======================================
+ Hits         2192     2200    +8     
  Misses          6        6           
  Partials        7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant