WIP: start building git mob api

list all authors in a Map, make it easy to access and iterate through authors.

src/commands/solo.js

@@ -3,7 +3,7 @@ const { mob } = require("../git/commands");
 
 function soloCommand() {
   return vscode.commands.registerCommand("gitmob.solo", function () {
-    mob.solo();
+    mob.removeGitMobSection();
     vscode.commands.executeCommand("gitmob.reload");
   });
 }

src/ext-config/solo-after-commit.js

@@ -17,7 +17,7 @@ let watch = null;
 function soloSwitch(coAuthorProvider, afterCommitOn) {
   if (afterCommitOn) {
     watch = watchForCommit(function () {
-      mob.solo();
+      mob.removeGitMobSection();
       coAuthorProvider.reloadData();
     });
   } else {

src/git/commands.js

@@ -3,6 +3,7 @@ const { promisify } = require("util");
 const { logIssue } = require("../errors/log-issue");
 const { compare } = require("../semver/compare");
 const { GitExt } = require("../vscode-git-extension/git-ext");
+// const { gitMessage, gitMessagePath } = require("./git-mob-api/git-message");
 // const { commitTemplatePath } = require("./git-mob-api/git-message");
 const { silentRun } = require("./silent-run");
 
@@ -122,12 +123,12 @@ function addRepoAuthor({ commandKey, name, email }) {
 
 function setCurrent(coAuthorList) {
   // setCommitTemplate();
-  solo();
+  removeGitMobSection();
   for (const author of coAuthorList) {
     addCoAuthor(author.toString());
   }
 
-  gitMessage(gitMessagePath()).writeCoAuthors(coAuthorList);
+  // gitMessage(gitMessagePath()).writeCoAuthors(coAuthorList);
 
   return current();
 }
@@ -136,7 +137,7 @@ function changeAuthor(authorKey) {
   return format(handleResponse(`npx git mob -o ${authorKey}`));
 }
 
-function solo() {
+function removeGitMobSection() {
   return silentRun(`git config --remove-section git-mob`);
 }
 
@@ -171,12 +172,13 @@ module.exports = {
   config: {
     get,
     has,
+    set,
   },
   mob: {
     current,
     setCurrent,
     listAll,
-    solo,
+    removeGitMobSection,
     gitMobLatest,
     installGitMob,
     changeAuthor,

src/git/git-mob-api/author.js

@@ -0,0 +1,19 @@
+class Author {
+  constructor(key, name, email) {
+    this.key = key;
+    this.name = name;
+    this.email = email;
+  }
+
+  format() {
+    return `Co-authored-by: ${this.toString()}`;
+  }
+
+  toString() {
+    return `${this.name} <${this.email}>`;
+  }
+}
+
+module.exports = {
+  Author,
+};

src/git/git-mob-api/git-authors/index.js

@@ -2,6 +2,7 @@ const fs = require("fs");
 const os = require("os");
 const path = require("path");
 const { promisify } = require("util");
+const { Author } = require("../author");
 
 const gitCoauthorsPath =
   process.env.GITMOB_COAUTHORS_PATH ||
@@ -105,10 +106,11 @@ function gitAuthors(readFilePromise, writeFilePromise, overwriteFilePromise) {
 
     toList(authors) {
       const entries = Object.entries(authors.coauthors);
-      return entries.map((authorParts) => {
-        const [initials, { name, email }] = authorParts;
-        return [initials, name, email].join(" ");
-      });
+      const authorMap = new Map();
+      for (let [key, { name, email }] of entries) {
+        authorMap.set(key, new Author(key, name, email));
+      }
+      return authorMap;
     },
   };
 }

src/git/git-mob-api/git-authors/index.spec.js

@@ -1,4 +1,5 @@
 const { gitAuthors } = require(".");
+const { Author } = require("../author");
 
 const validJsonString = `
 {
@@ -74,10 +75,10 @@ test("create an organised string list of .git-coauthors", async () => {
 
   const json = await authors.read();
   const authorList = authors.toList(json);
-  const expectAuthorList = [
-    "jd Jane Doe jane@findmypast.com",
-    "fb Frances Bar frances-bar@findmypast.com",
-  ];
+  const expectAuthorList = new Map([
+    ["jd", new Author("jd", "Jane Doe", "jane@findmypast.com")],
+    ["fb", new Author("fb", "Frances Bar", "frances-bar@findmypast.com")],
+  ]);
   expect(expectAuthorList).toEqual(authorList);
 });
 

src/git/git-mob-api/index.js

@@ -0,0 +1,16 @@
+const { mob } = require("../commands");
+const { gitAuthors } = require("./git-authors");
+
+async function getAllAuthors() {
+  const gitMobAuthors = gitAuthors();
+  return gitMobAuthors.toList(await gitMobAuthors.read());
+}
+
+function addCoAuthors(keys) {
+  mob.removeGitMobSection();
+}
+
+module.exports = {
+  addCoAuthors,
+  getAllAuthors,
+};

src/mob-authors.js

@@ -71,7 +71,7 @@ class MobAuthors {
       gitTemplate.writeCoAuthors(authorsSelected);
       setMob = list.filter((author) => currentMob.includes(author.email));
     } else {
-      mob.solo();
+      mob.removeGitMobSection();
       gitTemplate.removeCoAuthors();
       setMob = [];
     }