Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-mob as dev dependency #44

Closed
BuZZ-dEE opened this issue Aug 5, 2020 · 6 comments
Closed

git-mob as dev dependency #44

BuZZ-dEE opened this issue Aug 5, 2020 · 6 comments
Labels
enhancement New feature or request hacktoberfest help wanted Extra attention is needed

Comments

@BuZZ-dEE
Copy link

BuZZ-dEE commented Aug 5, 2020

Implement / allow to use git-mob from package.json / project devDependencies.

Summary

Allow the user to toggle a setting to use Git Mob cli as a devDependencies or as a global package.

By default, it should use global git mob.

Global command is git mob <initials>

Local command is npx git mob <initials>

@rkotze
Copy link
Owner

rkotze commented Aug 7, 2020

Hello @BuZZ-dEE

Could you explain a little more about the reasoning and benefits of adding git-mob to the dev dependencies?

I know it would be typical to have it as a listed dependency but git-mob needs to be installed globally for it to work and there is no place in the package.json for globals as far as I know.

@BuZZ-dEE
Copy link
Author

BuZZ-dEE commented Aug 7, 2020

@rkotze to run a dependency from the project node_modules, you can use npx, e.g.

npx git mob

@rkotze
Copy link
Owner

rkotze commented Aug 7, 2020

If you install npm i -D git-mob into a project and run npx git mob this does work from the command line.

Do you want the vs code extension to support the npx approach?

@BuZZ-dEE
Copy link
Author

Yes

@rkotze rkotze added the enhancement New feature or request label Oct 1, 2020
@rkotze rkotze added hacktoberfest help wanted Extra attention is needed labels Oct 1, 2020
rkotze added a commit that referenced this issue Oct 11, 2020
For npx to work with git the module needs to be installed.

#44
rkotze added a commit that referenced this issue Oct 11, 2020
rkotze added a commit that referenced this issue Oct 11, 2020
The path is essential to run Git Mob commands it the right folder

#44
@rkotze
Copy link
Owner

rkotze commented Oct 15, 2020

I've started this work, however, having this issue that I've posted on stack overflow.

https://stackoverflow.com/questions/64344898/cant-pass-right-number-of-args-via-nodejs-spawnsync

rkotze added a commit that referenced this issue Oct 16, 2020
rkotze added a commit that referenced this issue Oct 17, 2020
The double back slash is needed when using npx and add-coauthor on Windows. Not sure why.

#44
rkotze added a commit that referenced this issue Oct 17, 2020
Provide install buttons for git mob cli to choose between global or local.

#44
rkotze added a commit that referenced this issue Oct 17, 2020
Install options are only needed when the cli is not installed, the context command is used to handle this and is accessible in when clauses.

#44
rkotze added a commit that referenced this issue Oct 18, 2020
Ensure git mob cli install options are provided when it is not detected.

#44
@rkotze
Copy link
Owner

rkotze commented Oct 18, 2020

Deployed in version 1.9.0

@rkotze rkotze closed this as completed Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants