-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support commits with inline message #22
Comments
We could use the prepare-commit-msg hook. Tested it with an inline message and it works with a trailer. Inside the hook we could use the plumbing command
|
Yeah I agree if we ran commit with -m or --message i would expect co-author to show. 👍 |
Since we agree on the approach, I've changed this from a question to an enhancement. |
Plan is to allow for a customisable approach to setup a prepare-commit-msg hook to enable inline message. I think it would be risk for git-mob to install the hook into project which might already them setup and potentially breaking it. Fallback will still be using the standard git template with the option to use the prepare hook.
Solved in release v0.4.0. |
Commits made with the -m or --message option won't have the editor invoked, so it won't read the commit template to prepopulate the commit message. That means git mob doesn't work with this style of committing.
Committing with an inline message is discouraged for many reasons, but it's still a common practice.
It'd be surprising behaviour if you're in a mob but an inlined commit doesn't have co-authors.
The text was updated successfully, but these errors were encountered: