Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Create global coauthor file #125

Merged
merged 3 commits into from
May 5, 2024
Merged

Fix: Create global coauthor file #125

merged 3 commits into from
May 5, 2024

Conversation

rkotze
Copy link
Owner

@rkotze rkotze commented May 5, 2024

Description

When creating the global git-coauthor file provide the global path internally instead of using the pathToCoAuthors fn.

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • All tests and linting (npm run checks) has passed locally and any fixes were made for failures
  • I kept my pull requests small so it can be reviewed easier

Pull request type

Please check the type of change your PR introduces:

  • Bugfix

What is the current behaviour?

If a local .git-coauthor file is fine it will write the changes their instead of globally.

Issue URL:

What is the new behaviour?

Creating a global .git-coauthor file will only check and create a global file.

Does this introduce a breaking change?

  • Yes
  • No

@rkotze rkotze self-assigned this May 5, 2024
@rkotze rkotze merged commit 965bec4 into master May 5, 2024
4 checks passed
@rkotze rkotze deleted the create-coauthor-file branch May 5, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant