Fix errors for XO v0.59.3

.xo-config

@@ -50,6 +50,7 @@
     "unicorn/no-array-callback-reference": "off",
     "unicorn/prefer-module": 0,
     "unicorn/no-process-exit": 0,
+    "unicorn/prevent-abbreviations": "off",
     "node/prefer-global/process": 0,
     "n/prefer-global/process": 0,
     "n/file-extension-in-import": 0,

package.json

@@ -25,7 +25,7 @@
     "url": "git@github.com:rkotze/git-mob.git"
   },
   "engines": {
-    "node": ">=14"
+    "node": ">=16"
   },
   "keywords": [
     "cli",
@@ -55,7 +55,7 @@
     }
   ],
   "devDependencies": {
-    "eslint-plugin-jest": "^27.6.0",
-    "xo": "^0.54.1"
+    "eslint-plugin-jest": "^28.8.3",
+    "xo": "^0.59.3"
   }
 }

packages/git-mob-core/src/git-mob-api/fetch/http-fetch.ts

@@ -9,7 +9,7 @@ async function httpFetch(
   url: string,
   options: https.RequestOptions
 ): Promise<BasicResponse> {
-  return new Promise((fulfil, reject) => {
+  return new Promise((resolve, reject) => {
     const httpRequest = https
       .request(url, options, response => {
         let chunkedData = '';
@@ -19,7 +19,7 @@ async function httpFetch(
         });
 
         response.on('end', () => {
-          fulfil({
+          resolve({
             statusCode: response.statusCode,
             // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
             data: JSON.parse(chunkedData),

packages/git-mob-core/src/git-mob-api/git-message/index.ts

@@ -1,4 +1,4 @@
-import { readFile, writeFile } from 'node:fs';
+import { readFile, writeFile } from 'node:fs/promises';
 import { EOL } from 'node:os';
 import { type Author } from '../author';
 
@@ -7,32 +7,24 @@ function fileExists(error: NodeJS.ErrnoException) {
 }
 
 async function append(messagePath: string, newAuthors: string): Promise<void> {
-  return new Promise((resolve, reject) => {
-    readFile(messagePath, 'utf8', (error, data) => {
-      if (error && fileExists(error)) reject(error);
+  const data = await read(messagePath);
 
-      let result = newAuthors;
-      if (data) {
-        result = data.replace(/(\r\n|\r|\n){1,2}Co-authored-by.*/g, '') + newAuthors;
-      }
+  let result = newAuthors;
+  if (data) {
+    result = data.replaceAll(/(\r\n|\r|\n){1,2}Co-authored-by.*/g, '') + newAuthors;
+  }
 
-      writeFile(messagePath, result, error => {
-        if (error) reject(error);
-
-        resolve();
-      });
-    });
-  });
+  await writeFile(messagePath, result);
 }
 
 async function read(messagePath: string) {
-  return new Promise((resolve, reject) => {
-    readFile(messagePath, 'utf8', (error, data) => {
-      if (error && fileExists(error)) reject(error);
-
-      resolve(data);
-    });
-  });
+  try {
+    return await readFile(messagePath, { encoding: 'utf8' });
+  } catch (error: unknown) {
+    if (error && fileExists(error as Error)) {
+      throw error as Error;
+    }
+  }
 }
 
 function formatCoAuthorList(coAuthorList: Author[]): string {

packages/git-mob-core/tsconfig.prod.json

@@ -12,7 +12,9 @@
 
     /* Language and Environment */
     "target": "es2017" /* Set the JavaScript language version for emitted JavaScript and include compatible library declarations. */,
-    // "lib": [],                                        /* Specify a set of bundled library declaration files that describe the target runtime environment. */
+    "lib": [
+      "ES2021"
+    ] /* Specify a set of bundled library declaration files that describe the target runtime environment. */,
     // "jsx": "preserve",                                /* Specify what JSX code is generated. */
     // "experimentalDecorators": true,                   /* Enable experimental support for TC39 stage 2 draft decorators. */
     // "emitDecoratorMetadata": true,                    /* Emit design-type metadata for decorated declarations in source files. */
@@ -27,7 +29,7 @@
     /* Modules */
     "module": "NodeNext" /* Specify what module code is generated. */,
     // "rootDir": "src" /* Specify the root folder within your source files. */,
-   // "moduleResolution": "node" /* Specify how TypeScript looks up a file from a given module specifier. */,
+    // "moduleResolution": "node" /* Specify how TypeScript looks up a file from a given module specifier. */,
     // "baseUrl": "./",                                  /* Specify the base directory to resolve non-relative module names. */
     // "paths": {},                                      /* Specify a set of entries that re-map imports to additional lookup locations. */
     "rootDirs": [

packages/git-mob-core/tsconfig.test.json

@@ -12,7 +12,9 @@
 
     /* Language and Environment */
     "target": "es2017" /* Set the JavaScript language version for emitted JavaScript and include compatible library declarations. */,
-    // "lib": [],                                        /* Specify a set of bundled library declaration files that describe the target runtime environment. */
+    "lib": [
+      "ES2021"
+    ] /* Specify a set of bundled library declaration files that describe the target runtime environment. */,
     // "jsx": "preserve",                                /* Specify what JSX code is generated. */
     // "experimentalDecorators": true,                   /* Enable experimental support for TC39 stage 2 draft decorators. */
     // "emitDecoratorMetadata": true,                    /* Emit design-type metadata for decorated declarations in source files. */

packages/git-mob/package.json

@@ -63,12 +63,14 @@
   ],
   "dependencies": {
     "common-tags": "^1.8.2",
-    "git-mob-core": "^0.9.0",
-    "minimist": "^1.2.8"
+    "git-mob-core": "^0.9.3",
+    "minimist": "^1.2.8",
+    "update-notifier": "^7.3.1"
   },
   "devDependencies": {
     "@ava/typescript": "^5.0.0",
     "@types/common-tags": "^1.8.4",
+    "@types/minimist": "^1.2.5",
     "@types/node": "^22.7.4",
     "@types/sinon": "^17.0.3",
     "ava": "^6.1.3",
@@ -77,8 +79,7 @@
     "rimraf": "^6.0.1",
     "sinon": "^19.0.2",
     "tempy": "^3.1.0",
-    "typescript": "^5.6.2",
-    "update-notifier": "^7.3.1"
+    "typescript": "^5.6.2"
   },
   "ava": {
     "files": [

packages/git-mob/src/git-add-coauthor.ts

@@ -36,7 +36,7 @@ await execute(argv)
   .then(() => {
     process.exit(0);
   })
-  .catch((error: Error) => {
-    console.error(red(error.message));
+  .catch((error: unknown) => {
+    console.error(red((error as Error).message));
     process.exit(1);
   });

tsconfig.json

@@ -12,7 +12,9 @@
 
     /* Language and Environment */
     "target": "es2017" /* Set the JavaScript language version for emitted JavaScript and include compatible library declarations. */,
-    // "lib": [],                                        /* Specify a set of bundled library declaration files that describe the target runtime environment. */
+    "lib": [
+      "ES2021"
+    ] /* Specify a set of bundled library declaration files that describe the target runtime environment. */,
     // "jsx": "preserve",                                /* Specify what JSX code is generated. */
     // "experimentalDecorators": true,                   /* Enable experimental support for TC39 stage 2 draft decorators. */
     // "emitDecoratorMetadata": true,                    /* Emit design-type metadata for decorated declarations in source files. */