Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔥 Remove delete and edit commands #163

Merged
merged 7 commits into from
Oct 27, 2024
Merged

🔥 Remove delete and edit commands #163

merged 7 commits into from
Oct 27, 2024

Conversation

rkotze
Copy link
Owner

@rkotze rkotze commented Oct 24, 2024

Removing these commands because I think they are low value and not worth maintaining. There are easy alternative methods to update the .git-coauthor file. See the read me for examples.

Following commands removed:

  • git delete-coauthor
  • git edit-coauthor

Created this discussion thread.

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • All tests and linting (npm run checks) has passed locally and any fixes were made for failures
  • I kept my pull requests small so it can be reviewed easier

Pull request type

  • Remove low value features

Does this introduce a breaking change?

  • Yes

Other information

#83 Removed JS file managing read/writes to co-author file. Migrate the colours file to TS.

Removing this cmds because it don't think they are useful and there are easy methods to update the .git-coauthor file. See the readme.
@rkotze rkotze marked this pull request as ready for review October 27, 2024 15:35
@rkotze rkotze self-assigned this Oct 27, 2024
@rkotze rkotze merged commit 63efb46 into master Oct 27, 2024
4 checks passed
@rkotze rkotze deleted the remove-edit-delete branch October 27, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant