Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate esbuild to bundle modules #82

Merged
merged 15 commits into from
Sep 3, 2022
Merged

Integrate esbuild to bundle modules #82

merged 15 commits into from
Sep 3, 2022

Conversation

rkotze
Copy link
Owner

@rkotze rkotze commented Aug 21, 2022 •
edited
Loading

First steps to integrating a build tool to compile git mob code. Adding TypeScript will be a follow on task.

  • Add esbuild package and script
  • Integrate into npm build scripts
  • Integrate build script into both test and test watch script
  • Migrate git mob command
  • Migrate git solo command
  • Migrate git add co-authors command
  • Migrate git delete co-authors command
  • Migrate git edit co-authors command
  • Migrate git suggest co-authors command
  • Migrate git mob print command
  • Replace requires with import statements
  • Update CI Github actions to follow the new build process
  • Update publish process to build and minify process

More info on npm life cycle scripts

rkotze added 15 commits August 21, 2022 18:05
@rkotze
Integrate esbuild to support old node versions
0d1bbf4 
Will look into integrate this with TypeScript at some point afterwards.
@rkotze
⚡ Move solo over to bundler
9dc3d42 
Add minify option to config.
@rkotze
Build the dist files
c953604 
Run build command to compile git mob commands and fix failing tests.
@rkotze
Update test scripts to build source first
aa57b8a 
Test and test watch npm scripts build source first then run tests.

Fix watch issue in ava, any files changing in on disk need to be ignored because ava watches all files in project.

CI does not need to build because that is part of the test scripts now.
@rkotze
Git mob & solo use import over require.
d20a488
@rkotze
Migrate add coauthors script
16583ec
@rkotze
Migrate git delete coauthor
c67e8f4
@rkotze
Migrate git edit coauthor
a1c8f23
@rkotze
Migrate print and suggest commands
8753623
@rkotze
Compile AVA tests and remove require
79a9ee7 
Add a failing test to check sourcemap in CI. Not working locally on Windows.
@rkotze
Convert all to es modules
34c39e8
@rkotze
Fix post install script
62d1e6f 
File pointing to src instead of dist
@rkotze
Improve the CI flow using npm life cycle
c67f2ba 
When running install: postinstall runs first and is followed by prepare.

prepack will run before publish command.

More details here: https://docs.npmjs.com/cli/v8/using-npm/scripts
@rkotze
Fix lint error, don't ignore src spec
18c97df 
https://github.com/avajs/eslint-plugin-ava/blob/main/docs/rules/no-ignored-test-files.md
@rkotze
Test minified version before publishing
2654b81
@rkotze rkotze merged commit bc7c011 into master Sep 3, 2022
@rkotze rkotze deleted the add-esbuild branch September 3, 2022 20:57
@rkotze rkotze changed the title Integrate esbuild to support old node versions Integrate esbuild to bundle modules Sep 4, 2022
@rkotze rkotze mentioned this pull request Sep 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rkotze