This repository has been archived by the owner on Feb 24, 2020. It is now read-only.
common/cgroup: add mountFsRO() helper function #2829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| func mountFsRO(mountPoint string) error { | ||
| var flags uintptr | ||
|
|
||
| flags = syscall.MS_BIND | |
There was a problem hiding this comment.
Just collapse this into the declaration on line 404
There was a problem hiding this comment.
@jonboulle Thank you for feedback, will update tge pr soon
|
thanks! one small comment but lgtm after that |
There are some places in the common/cgroup/cgroup.go which contain the same code which collects flags to mount a filesystem in read-only mode and calls mount system call with the given flags and a filesystem source/target. This patch adds mountFsRO() helper function to prevent code duplication. Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
|
@jonboulle updated |
|
LGTM but as there's a release going on today let's hold off on merging until after that |
|
Can one of the admins verify this patch? |
|
ok to test |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some places in the common/cgroup/cgroup.go which contain the same
code which collects flags to mount a filesystem in read-only mode and calls
mount system call with the given flags and a filesystem source/target.
This patch adds mountFsRO() helper function to prevent code duplication.
Signed-off-by: Alexander Kuleshov kuleshovmail@gmail.com