-
Notifications
You must be signed in to change notification settings - Fork 882
stage1: improve duplicate mount-volume detection #3666
Conversation
/cc @euank See appc/spec#687 for the corresponding fix directly in appc/spec. |
This does not fix all of #3663 The important one is that multiple mounts with the same target should work if they have different names, but that case still doesn't work with this PR. Specifically:
|
@euank This is because stage0 is de-duplicating those mounts. Other stage1s work because they don't check that all volumes are covered by a mount. Looking at pod spec I think fly is being too strict in performing this check. I'll queue a commit on top of this PR to relax it. |
99e436b
to
e2b4244
Compare
e2b4244
to
1916ca7
Compare
Rebased on master, PTAL. @euank can you re-check if this now implements the proper behavior from wrapper flags point of view? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this allows a solution to our wrapper woes.
The other changes LGTM as well.
Breaking change: volumes with duplicate names are now rejected.
This PR adds error-checking for duplicate volume names. Also, it adds path cleaning when de-duplicating mounts targets. Tests are slightly adjusted to check both cases.
Fixes #3663