Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web GUI update #141

Merged
merged 2 commits into from
Oct 10, 2014
Merged

Web GUI update #141

merged 2 commits into from
Oct 10, 2014

Conversation

vernak2539
Copy link
Contributor

Updated the Web GUI to use bootstrap and have a cleaner design (fully responsive). Removed the big logo at the top, since most people are interested in the published modules and not a header. Put a static header on top, and it will be easy to add login buttons when it gets to that point.

Put pictures below, but running locally would probably be better.

Desktop + Mobile
screen shot 2014-10-07 at 2 38 56 pm

(1) Large, (2) Large with vertical scroll
screen shot 2014-10-07 at 2 34 39 pm
screen shot 2014-10-07 at 2 35 12 pm

(1) Medium/Small, (2) Medium/Small with vertical scroll
screen shot 2014-10-07 at 2 34 30 pm
screen shot 2014-10-07 at 2 35 05 pm

Extra Small
screen shot 2014-10-07 at 2 34 47 pm

@dsuckau
Copy link

dsuckau commented Oct 8, 2014

Yeah, looks great.

@lxlang
Copy link

lxlang commented Oct 9, 2014

👍

rlidwka added a commit that referenced this pull request Oct 10, 2014
@rlidwka rlidwka merged commit 08f2187 into rlidwka:master Oct 10, 2014
@rlidwka
Copy link
Owner

rlidwka commented Oct 10, 2014

Merging. Thanks!

@vernak2539 vernak2539 deleted the web-gui branch October 10, 2014 15:50
@rlidwka
Copy link
Owner

rlidwka commented Nov 4, 2014

Put a static header on top, and it will be easy to add login buttons when it gets to that point.

@vernak2539 , I added login button near the logo in 67b4528, but it doesn't quite fit there. Can you take a look to see how it could be improved?

@vernak2539
Copy link
Contributor Author

@rlidwka, yeah I have an idea of what we could do. I'll probably able to look at it in the next few days. Is there a specific branch you're working on?

@rlidwka
Copy link
Owner

rlidwka commented Nov 4, 2014

Is there a specific branch you're working on?

No, it's all in the master branch right now.

@vernak2539
Copy link
Contributor Author

okay no worries. Should have something this week

@rlidwka
Copy link
Owner

rlidwka commented Nov 30, 2014

@vernak2539, thanks again for the update.

I wanted to ask, was there any reason to use "position: fixed" for the main header there?

It creates an issue with anchors in readmes (<a name=...>, <h1 id=...>, etc.), they are appear under the header. We could use some css trickery, but I'm thinking about just use static positioning for it like most websites do.

@vernak2539
Copy link
Contributor Author

I guess the only reason was to keep the header, and subsequently the search bar, always at the top of the page.

I didn't even think about the anchors in the readme files, but you're right; this would cause that behavior.

I think the static positioning would be just fine. Especially for people contributing in the future. I can change it, but if you got it no worries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants