Change _npmUser.name to author.name for entries #352
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #173 with missing author name in the web interface
|
+1 |
|
Looks like a straight-forward change 👍 Some CI errors — possibly flaky tests? |
|
@gillesdemey yeah looked like some network errors on node 0.10 only and it was several days after the actual commit so not really sure what was up with that. |
|
+1 |
dgaya
added a commit
to fl4re/sinopia
that referenced
this pull request
Mar 8, 2016
Change _npmUser.name to author.name for entries rlidwka#352
|
+1 I have encountered this problem can be solved this way |
gaelreyrol
pushed a commit
to Soyhuce/cinabre
that referenced
this pull request
May 31, 2016
jachstet-sea
added a commit
to jachstet-sea/verdaccio
that referenced
this pull request
Oct 6, 2016
…the web interface
|
Closing, it's been applied to active forks anyway |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #173 with missing author name in the web interface