Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deps, make compile on Node v4 & 5 #367

Closed
wants to merge 2 commits into from
Closed

Update deps, make compile on Node v4 & 5 #367

wants to merge 2 commits into from

Conversation

caseyWebb
Copy link

Used updtr to update deps, and removed npm-shrinkwrap.json (I can regenerate this if need-be).

node-gyp doesn't complain (as much — no errors, only warnings) during install w/ node v4/5 now.

Note: I use Greenkeeper to make sure the deps in all my projects stay up to date; I highly recommend it.

@bestander
Copy link

closes #311

@bestander
Copy link

@rlidwka, this bug seems to block a lot of people and PR seems very small.
Any chance you could accept it?
Thanks.

@caseyWebb
Copy link
Author

Let me double check and make sure this is all working. Locally it's good, but Travis appears to be failing.

@mima0815
Copy link

I don't know much about travis, but it seems to me that travis does not have an C++11 Compiler available.

make: Entering directory `/home/travis/build/rlidwka/sinopia/node_modules/fs-ext/build'
  CXX(target) Release/obj.target/fs-ext/fs-ext.o
In file included from ../fs-ext.cc:27:0:
../../nan/nan.h:41:3: error: #error This version of node/NAN/v8 requires a C++11 compiler
In file included from /home/travis/.node-gyp/5.4.1/include/node/node.h:42:0,

Have a look here: http://stackoverflow.com/questions/22111549/travis-ci-with-clang-3-4-and-c11

The travis config has to be adapted also.

dgaya added a commit to fl4re/sinopia that referenced this pull request Mar 8, 2016
Update deps, make compile on Node v4 & 5 rlidwka#367
@landru29
Copy link

landru29 commented Jun 8, 2016

Waiting for the fix. The project is not usable as it is : impossible to install

@bestander
Copy link

I ended up using npm pack + npm install <location on disk> for my e2e tests.
Although that is just a tiny piece of what sinopia does it was good enough for me

@caseyWebb caseyWebb closed this Mar 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants