Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify default directly in sensmodel arg #227

Merged
merged 5 commits into from
Aug 2, 2024
Merged

Conversation

Bisaloo
Copy link
Collaborator

@Bisaloo Bisaloo commented Feb 20, 2021

I like this approach because:

  • it simplifies the code by relying on R idioms
  • it makes clear what the defaults are directly in the documentation

If you like this, I can review all functions to see where this can be implemented.

@thomased
Copy link
Collaborator

Yeah that's a great idea — the more explicit the defaults, the better.

@Bisaloo Bisaloo force-pushed the simplify-defaults branch from 11ecb6e to 69a9dea Compare July 17, 2023 16:52
@Bisaloo
Copy link
Collaborator Author

Bisaloo commented Jul 17, 2023

@thomased, thoughts on 852814d? Do you find it clearer or no?

@Bisaloo Bisaloo force-pushed the simplify-defaults branch from 69a9dea to 484f4ca Compare July 17, 2023 16:53
@Bisaloo Bisaloo force-pushed the simplify-defaults branch from 484f4ca to 852814d Compare July 11, 2024 09:38
@Bisaloo Bisaloo marked this pull request as ready for review July 11, 2024 09:44
@Bisaloo Bisaloo requested a review from thomased July 11, 2024 10:12
@Bisaloo Bisaloo merged commit 0c4fb16 into master Aug 2, 2024
7 checks passed
@Bisaloo Bisaloo deleted the simplify-defaults branch August 2, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants