assert: fix deepEqual RangeError: Maximum call stack size exceeded

Fixes: nodejs#13314 Refs: nodejs#6416
rmdm · May 30, 2017 · f299cfa · f299cfa
1 parent bb91879
commit f299cfa
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/lib/assert.js b/lib/assert.js
@@ -269,9 +269,7 @@ function _deepEqual(actual, expected, strict, memos) {
 
   const actualPosition = memos.actual.map.get(actual);
   if (actualPosition !== undefined) {
-    if (actualPosition === memos.expected.map.get(expected)) {
-      return true;
-    }
+    return actualPosition === memos.expected.map.get(expected);
   } else {
     memos.actual.map.set(actual, memos.actual.position++);
   }

diff --git a/test/parallel/test-assert.js b/test/parallel/test-assert.js
@@ -535,6 +535,18 @@ a.throws(makeBlock(thrower, TypeError), function(err) {
 
   a.throws(makeBlock(a.deepEqual, d, e), /AssertionError/);
   a.throws(makeBlock(a.deepStrictEqual, d, e), /AssertionError/);
+
+  // https://github.com/nodejs/node/issues/13314
+  const f = {};
+  f.ref = f;
+
+  const g = {};
+  g.ref = g;
+
+  const h = {ref: g};
+
+  a.throws(makeBlock(a.deepEqual, f, h), /AssertionError/);
+  a.throws(makeBlock(a.deepStrictEqual, f, h), /AssertionError/);
 }
 // GH-7178. Ensure reflexivity of deepEqual with `arguments` objects.
 const args = (function() { return arguments; })();