Prevent setting nil headers #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the header lambda returns `nil`, the header is still set with a value of `null`. This PR changes that and does not set headers that resolve to `nil`.
|
@rmosolgo is this PR something you would consider useful? I need it in the project I'm currently working on. |
rmosolgo
reviewed
Feb 23, 2024
|
Hey, thanks for this improvement! Sorry it took me so long to review it. I switched the check from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the header lambda returns
nil, the header is still set with a value ofnull.This PR changes that and does not set headers that resolve to
nil.