Merge pull request #5195 from rmosolgo/resolver-inherit-description

Make resolvers inherit description from superclass
rmosolgo · Dec 27, 2024 · ca9ff0e · ca9ff0e
2 parents 1b1d382 + c64dec8
commit ca9ff0e
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/lib/graphql/schema/resolver.rb b/lib/graphql/schema/resolver.rb
@@ -22,6 +22,7 @@ class Resolver
       include Schema::Member::GraphQLTypeNames
       # Really we only need description & comment from here, but:
       extend Schema::Member::BaseDSLMethods
+      extend Member::BaseDSLMethods::ConfigurationExtension
       extend GraphQL::Schema::Member::HasArguments
       extend GraphQL::Schema::Member::HasValidators
       include Schema::Member::HasPath

diff --git a/spec/graphql/schema/resolver_spec.rb b/spec/graphql/schema/resolver_spec.rb
@@ -54,6 +54,8 @@ class Resolver3 < Resolver1
     class Resolver4 < BaseResolver
       type Integer, null: false
 
+      description "Adds object.value to ast_node.name.size"
+
       extras [:ast_node]
       def resolve(ast_node:)
         object.value + ast_node.name.size
@@ -724,6 +726,14 @@ def exec_query(*args, **kwargs)
     end
   end
 
+  describe "description" do
+    it "is inherited" do
+      expected_desc = "Adds object.value to ast_node.name.size"
+      assert_equal expected_desc, ResolverTest::Resolver4.description
+      assert_equal expected_desc, ResolverTest::Resolver5.description
+    end
+  end
+
   describe "when applied to a field" do
     it "gets the field's description" do
       assert_nil ResolverTest::Schema.find("Query.resolver3").description