Make it so you can opt out of object authorization #3446
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3429
I can't say I recommend it, but if it's really adding up, this makes it possible (and tested) to override
Schema::Object.authorized_new
and bypass authorization.I also investigated an option for disabling built-in authorization at runtime, but I found it put too much complexity in the code (https://github.com/rmosolgo/graphql-ruby/compare/skip-built-in-auth).
Instead, this approach consolidates tracing and logic in
.authorized_new
, then tests to confirm that it can be overridden (including forDynamicFields
, which implements__typename
).So, with this PR, you could opt out by adding:
and