-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve formatting in Feature and Scenario descriptions #154
Comments
Hi @andrewesweet, why your feature files has such formating? isn't it easier to adjust the feature description instead of trying to fix that in Cukedoctor? Also for your PR #155, please rebase your branch with cukedoctor master branch or create a new branch on top of master and add your changes on this branch. It will be easier to review your changes. |
Sorry - I missed the lack of rebase, although the PR makes it obvious. Will fix. Regarding the formatting, the style shown in the Gherkin online reference and in the most commonly used IntelliJ plugin for Cucumber JVM both use indentation of Scenarios under features and align the descriptions accordingly. |
I've rebased master commits into your branch otherwise we would not be able to merge your PR because the repositories trees were different. Let's wait CI build and then merge the PR, thank you very much! |
The fix for this is available in |
Thank you! |
Cukedoctor currently passes along a Feature or Scenario description's leading whitespace to AsciiDoc, except the first line. She problem is that whitespace is often formatting the feature file rather than desired indentation of the description paragraph block in AsciiDoc. e.g. My features are indented one tab, so their descriptions are two tabs; my scenarios are indented two tabs, so their descriptions are indented three tabs etc..
I think Cukedoctor should look at the indentation of the first non-blank line of a description and trim however many character of leading whitespace are in that line off all other lines i.e. treat leading whitespace in the first line as formatting the feature file and any subsequent additional leading whitespace on other lines as formatting the description block.
E.g.
should be rendered as
as opposed to the current
The text was updated successfully, but these errors were encountered: