571 variable interpolation #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
iandjx
commented
Sep 30, 2024
•
iandjx
commented
- Enhanced the CrewAppForm component to handle variable choices and kickoff variables, including UI updates.
- Integrated variable selection and creation in SortableItem and TaskForm components.
- Added session variable update logic in StructuredInputForm with API integration.
- Refactored task building logic in agent-backend with helper functions and session variable interpolation.
- Simplified variable fetching logic in the database layer.
- Added new helper functions for task management in agent-backend.
- Improved session and task API logic to handle new variable-related features.
570 Add support for task output variables
iandjx
force-pushed
the
571-variable-interpolation
branch
from
e921be0
to
d3e0be8
Compare
tomlynchRNA
suggested changes
Oct 4, 2024
| isStructuredOutput, | ||
| variableIds: (variableIds || []).map(toObjectId) | ||
| variableIds: (variableIds || []).map(toObjectId), |
There was a problem hiding this comment.
A variable ID here can refer to a variable that was deleted
| const selectedAgents = agentIds?.map(a => agentChoices.find(ac => ac._id === a)); | ||
| const variableIdsOfSelectedAgents = selectedAgents?.map(a => a?.variableIds || []).flat(); | ||
| const variablesOfSelectedAgents = variableIdsOfSelectedAgents?.map(v => | ||
| variableChoices?.find(vc => vc._id === v) |
There was a problem hiding this comment.
The variable may not be found, suggest to filter this list for safety but also handle this in backend when saving tasks, agents, etc
| setKickOffVariables(v || []); | ||
| }} | ||
| options={combinedVariables.map(v => ({ | ||
| label: v.name, |
There was a problem hiding this comment.
Uncaught error here because the variable can be null see above comment
webapp/src/controllers/session.ts
Outdated
| crewAppVariables.push(...variables); | ||
|
|
||
| variables.forEach(variable => { | ||
| if (!crewAppVariables.some(v => (v._id as ObjectId).equals(variable._id))) { |
There was a problem hiding this comment.
variable can be null, need to handle or filter above
Added changes such that error gets returned if a non-existent variable is included when adding a new agent/task or editing an agent/task Added logic to fitler out undefined variables in crewapp form tested by
|
…gital/agentcloud into 571-variable-interpolation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.