Enhance Airbyte Integration with Connection Checks and Conditional Features #626
Conversation
iandjx
commented
Nov 1, 2024
•
iandjx
commented
- Added a function to check Airbyte connection status and integrated it into various components.
- Enhanced DatasourceTable and Datasources pages to conditionally enable features based on Airbyte availability.
- Implemented a new route and controller method to handle Airbyte connection checks.
- Updated Airbyte setup to include status checks and initialization logic.
iandjx
changed the title
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 6728867 |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -37,6 +40,12 @@ | |||
| const [deletingMap, setDeletingMap] = useState({}); | |||
| const [confirmClose, setConfirmClose] = useState(false); | |||
|
|
|||
| const goToDatasourcePage = (id: string) => { | |||
| if (isAirbyteEnabled) { | |||
| router.push(`/${resourceSlug}/datasource/${id}`); | |||
Check warning
Code scanning / CodeQL
Client-side URL redirect Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI 9 days ago
To fix the problem, we should avoid using user input directly in constructing the redirect URL. Instead, we can maintain a list of authorized redirects and choose from that list based on the user input. This ensures that only valid and safe URLs are used for redirection.
- Create a list of authorized
resourceSlugvalues. - Check if the
resourceSlugfromrouter.queryis in the list of authorized values. - Only perform the redirection if the
resourceSlugis authorized.
| @@ -42,5 +42,8 @@ | ||
|
|
||
| const authorizedResourceSlugs = ['validSlug1', 'validSlug2']; // Add all authorized slugs here | ||
| const goToDatasourcePage = (id: string) => { | ||
| if (isAirbyteEnabled) { | ||
| if (isAirbyteEnabled && authorizedResourceSlugs.includes(resourceSlug)) { | ||
| router.push(`/${resourceSlug}/datasource/${id}`); | ||
| } else { | ||
| toast.error('Unauthorized resource slug'); | ||
| } |
|
This approach looks to test the "/api/v1/health" endpoint. There might be a situation where the health check returns 200 but the bearer token stored in the webapp is invalid (since the health check endpoint doesn't require auth). Might be a good idea to add a second endpoint check to ensure that both airbyte is up and that the webapp has a valid bearer token |
…t request, adding ENV variable to env example to ensure that lack of the variable doesn't break the app
Addressed these issues in latest commits. |
