Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No support for collector over HTTPS #50

Open
poear opened this issue Jun 8, 2022 · 0 comments
Open

No support for collector over HTTPS #50

poear opened this issue Jun 8, 2022 · 0 comments

Comments

@poear
Copy link

poear commented Jun 8, 2022

I have run into an issue with specifying a collector which uses HTTPS.

I am no C++ dev but would it be easy to enable users to specify a collector url which is over https?
Maybe there is issues in the underlying impl. that I am missing but it looks like a quite trivial change in this piece of code?

zipkin-cpp-opentracing/zipkin/src/zipkin_http_transporter.cc

Line 11 in f695931

return std::string{"http://"} + collector_host + ":" +

poear added a commit to poear/zipkin-cpp-opentracing that referenced this issue Jun 8, 2022
@poear
Replaced collector host & port with base_url (rnburn#50)
d973173 
This is useful if the collector is using https.
@poear poear mentioned this issue Jun 8, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@poear