Opentracing 1.6 API support #42
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rnburn, will you, please, re-run the tests? It looks like there is something wrong with ci. |
|
@turchanov I think you need to rebase. The error you see is fixed after #38 |
turchanov
force-pushed
the
opentracing-1.6
branch
2 times, most recently
from
5582bea to
052c2e7
Compare
Implemented Clone(), ToTraceID(), ToSpanID(), extra variants of Log() methods for SpanContext. Test cases for Clone(), ToTraceID(), and ToSpanID().
turchanov
force-pushed
the
opentracing-1.6
branch
from
052c2e7 to
f19577d
Compare
|
@aledbf, thank you for the suggestion. It helped. |
|
@rnburn would you mind integration this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented Clone(), ToTraceID(), ToSpanID(), extra variants of Log()
methods for SpanContext. Test cases for Clone(), ToTraceID(), and ToSpanID().