implementing virtual functions for compatibility #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #29 (which is closed rn) |
|
@rnburn can this be tagged/released? I'd like to upgrade all the relevant tracing libraries in the nginx image used in kubernetes/ingress-nginx |
|
bumping that ^ if possible 🙏 |
|
@timmysilv - could I give you maintainer access? then you can cut a release and go through any other issues that need updating? |
|
sure, sounds fun! |
|
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is essentially a no-op, it just ensures that this library builds properly with opentracing-cpp v1.6.0.
Logintroduced: Support specifying timestamp with Log. opentracing/opentracing-cpp#109Cloneintroduced: Support copying span contexts. opentracing/opentracing-cpp#56This was previously attempted in #34 but
Logis needed as well. I'm hoping this can be done soon in order to upgrade tracing libraries used in kubernetes/ingress-nginx.