Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vovagusev #22

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Vovagusev #22

wants to merge 13 commits into from

Conversation

Invalid-coder
Copy link
Collaborator

@Invalid-coder Invalid-coder commented Feb 2, 2021

Description

Created some models with the highest 98.5% accuracy

How has this been tested?

  • Executed code few times from start to end without crashing
  • Only ran once
  • Code have dedicated unit tests

plt.plot(retVal.history['accuracy'], label = 'training accuracy')
plt.legend()

"""Is it bad when the learning curve looks almost like a line?
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You compare loss and accuracy at the same plot, that's why it looks a little weird.
For better visualization you could use separate plots for loss and accuracy:
plt.plot(retVal.history['accuracy'], label='train accuracy')
plt.plot(retVal.history['val_accuracy'], label='val accuracy')
plt.legend()

Copy link
Collaborator

@meanalexrin meanalexrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove facenet_keras.h5 from git :D
Storing models on the git itself is a bad tone
Just leave comments on where it should be downloaded

Other than that - LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants