Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Denysyefimov #6

Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

Denysyefimov #6

wants to merge 22 commits into from

Conversation

Detroiman
Copy link
Collaborator

Description

Please include summary of the change in english

How has this been tested?

  • Executed code few times from start to end without crashing
  • Only ran once
  • Code have dedicated unit tests

meanalexrin
meanalexrin approved these changes Feb 1, 2021
View reviewed changes
Copy link
Collaborator

@meanalexrin meanalexrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move your code to
denysyefimov_code/task...
And please fix flake warnings

Besides this - Looks Good To Me 👍

denysyefimov_task1/denysyefimov_houseprices.py Outdated Show resolved Hide resolved
denysyefimov_task1/denysyefimov_houseprices.py Outdated Show resolved Hide resolved
@meanalexrin meanalexrin self-requested a review February 1, 2021 09:52
meanalexrin
meanalexrin requested changes Feb 1, 2021
View reviewed changes
Copy link
Collaborator

@meanalexrin meanalexrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah, I was going to request changes but accidentally approved in previous comment
Please move code and fix warnings as it was mentioned in previous comment

Yullia
Yullia suggested changes Feb 8, 2021
View reviewed changes
Copy link

@Yullia Yullia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, fix flake warnings and errors

@Detroiman Detroiman requested a review from ARKAD97 as a code owner February 8, 2021 11:30
@Detroiman Detroiman requested a review from meanalexrin February 8, 2021 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yullia Yullia Yullia requested changes

@dlikhomanov dlikhomanov Awaiting requested review from dlikhomanov dlikhomanov is a code owner

@ARKAD97 ARKAD97 Awaiting requested review from ARKAD97 ARKAD97 is a code owner

@meanalexrin meanalexrin Awaiting requested review from meanalexrin meanalexrin is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Detroiman @Yullia @meanalexrin